Moti Asayag has posted comments on this change. Change subject: core: fix job properties in remove VmPool to show cluster name (#817366) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java Line 57: jobProperties.put(VdcObjectType.VdsGroups.name().toLowerCase(), getVdsGroupName()); if the cluster name returns null, it will be printed as 'null' string on the message. I'd suggest to put empty string in case the name is missing. -- To view, visit http://gerrit.ovirt.org/4612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f584c0a15c09923ee9bde5640666cdad5d4e81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
