David Caro has posted comments on this change. Change subject: Use static repos for a new layout ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/25295/4/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 21: CENTOS_MIRROR="http://centos.mirror.constant.com/"; Line 22: EPEL_MIRROR="http://linux.mirrors.es.net/"; Line 23: FEDORA_MIRROR="http://mirrors.kernel.org/"; Line 24: GLUSTER_MIRROR="http://download.gluster.org/"; Line 25: JPACKAGE_MIRROR="ftp://jpackage.hmdc.harvard.edu/"; You should declare STATIC_RP here as empty, to avoid environment variable injection (export STATIC_RP="blabla"; ./repo_closure_check.sh will use the exported value) Line 26: Line 27: die() { Line 28: local m="${1}" Line 29: echo "FATAL: ${m}" Line 114: if [ "${DISTRIBUTION}" = "el" ] \ Line 115: || [ "${DISTRIBUTION}" = "Centos" ]; then Line 116: repoclosure \ Line 117: -t \ Line 118: --repofrompath=check-custom,"${CUSTOM_URL}" ${STATIC_RP} \ I'd put this STATIC_RP on it's own line, as it is (or might be) another repository declaration, if put there, I'd expect it to be an option to the check-custom repository declaration Line 119: --repofrompath=check-base,"${CENTOS_MIRROR}/${DISTRIBUTION_VERSION}"/os/x86_64/ \ Line 120: --repofrompath=check-base-i386,"${CENTOS_MIRROR}/${DISTRIBUTION_VERSION}"/os/i386/ \ Line 121: --repofrompath=check-updates,"${CENTOS_MIRROR}/${DISTRIBUTION_VERSION}"/updates/x86_64/ \ Line 122: --repofrompath=check-extras,"${CENTOS_MIRROR}/${DISTRIBUTION_VERSION}"/extras/x86_64/ \ Line 132: -l check-base \ Line 133: -l check-base-i386 \ Line 134: -l check-jpackage-rhel5 \ Line 135: -l check-jpackage-generic \ Line 136: -r check-custom If STATIC_RP is declared above, you'll have to add before this line too, so it gets used for the check. ${STATIC_RP:+-l check-custom-static} \ Line 137: elif [ "${DISTRIBUTION}" = "fc" ] \ Line 138: || [ "${DISTRIBUTION}" = "Fedora" ]; then Line 139: repoclosure \ Line 140: -t \ Line 144: --repofrompath=check-updates-testing,"${FEDORA_MIRROR}"/fedora/updates/testing/"${DISTRIBUTION_VERSION}"/x86_64/ \ Line 145: -l check-fedora \ Line 146: -l check-updates \ Line 147: -l check-updates-testing \ Line 148: -r check-custom Same as above, about STATIC_RP Line 149: fi Line 150: } Line 151: Line 152: main() { -- To view, visit http://gerrit.ovirt.org/25295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44087b1d6f5aafa965ad8c0b9b23e8f8d4b949b2 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
