Liran Zelkha has uploaded a new change for review. Change subject: core: Ensure NonOperational state is saved ......................................................................
core: Ensure NonOperational state is saved A specific scenario in VdsUpdateRuntimeInfo does not save the NonOperational status to the database. This causes the host to get stuck in an unassigned status. Change-Id: I8e4c5d3dc49f48bf46609c91f13dededb43b630f Bug-Url: https://bugzilla.redhat.com/962180 Signed-off-by: lzel...@redhat.com <lzel...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/25298/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java index b535471..7ed2132 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java @@ -404,12 +404,15 @@ ResourceManager .getInstance() .getEventListener() - .vdsNonOperational(_vds.getId(), _vds.getNonOperationalReason(), false, false, + .vdsNonOperational(_vds.getId(), _vds.getNonOperationalReason(), false, true, Guid.Empty); } else { - log.infoFormat("Host {0} : {1} is already in NonOperational status. SetNonOperationalVds command is skipped.", + + log.infoFormat("Host {0} : {1} is already in NonOperational status for reason {2}. SetNonOperationalVds command is skipped.", _vds.getId(), - _vds.getName()); + _vds.getName(), + (_vds.getNonOperationalReason() != null) ? _vds.getNonOperationalReason().name() + : "unknown"); } } // rerun all vms from rerun list -- To view, visit http://gerrit.ovirt.org/25298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e4c5d3dc49f48bf46609c91f13dededb43b630f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
