Daniel Erez has uploaded a new change for review.
Change subject: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
......................................................................
webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
EnterIgnoringFocusHandler -> onPreviewNativeEvent:
execute 'enterPressed' on ONKEYDOWN event instead of
ONKEYPRESS to overcome an issue in newer Chrome/FF
browsers, in which the textarea doesn't catch the
ONKEYPRESS event. Consequently, pressing enter key
in a textarea won't break to a new line
(e.g. 'Custom Script' textarea).
Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/25289/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java
index 22257e0..3726173 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java
@@ -35,7 +35,7 @@
nativeEvent.stopPropagation();
event.cancel();
- if (event.getTypeInt() == Event.ONKEYPRESS) {
+ if (event.getTypeInt() == Event.ONKEYDOWN) {
enterPressed();
}
}
--
To view, visit http://gerrit.ovirt.org/25289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
