Daniel Erez has uploaded a new change for review. Change subject: webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event ......................................................................
webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event DialogBoxWithKeyHandlers -> onPreviewNativeEvent: remove ONKEYPRESS event as onKeyPress might be called twice (due to ONKEYDOWN event). Which causes double execution of OK command when pressing enter key in Network dialog. Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Bug-Url: https://bugzilla.redhat.com/1058652 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/25287/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java index 7f5fe12..7902931 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java @@ -15,7 +15,7 @@ protected void onPreviewNativeEvent(NativePreviewEvent event) { super.onPreviewNativeEvent(event); - if (keyPressHandler != null && event.getTypeInt() == Event.ONKEYPRESS) { + if (keyPressHandler != null && event.getTypeInt() == Event.ONKEYDOWN) { keyPressHandler.onKeyPress(event.getNativeEvent()); } } -- To view, visit http://gerrit.ovirt.org/25287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
