Arik Hadas has posted comments on this change. Change subject: core: extract parameters initialization from vdsUpEvent ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24798/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java: Line 15: Line 16: public MigrateBrokerVDSCommand(P parameters) { Line 17: super(parameters); Line 18: migMethod = VdsProperties.migrationMethodtoString(parameters.getMigrationMethod()); Line 19: log.infoFormat("Entered (vm_guid='{0}', srcHost='{1}', dstHost='{2}', method='{3}'", > this log redundant and can be removed. Done Line 20: parameters.getVmId().toString(), parameters.getSrcHost(), Line 21: parameters.getDstHost(), migMethod); Line 22: } Line 23: -- To view, visit http://gerrit.ovirt.org/24798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54501c64f9b0ff3cd2bb80d457a597d01328b8d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
