Roy Golan has posted comments on this change. Change subject: core: Change validation groups to inherit default ......................................................................
Patch Set 3: I'm not convinced the should inherit from Default. There maybe situation where we want to validate specific stuff in "Update" and ignore "Default" validations. If we want both we can give the validator both Default and Update but if we want a subset of checks we need to use the group we wanted. with inheritance you cant run only the specific checks you wanted. -- To view, visit http://gerrit.ovirt.org/4374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0774a4e9e4ea23d99702783291c181118fd2a309 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
