Yaniv Dary has posted comments on this change.

Change subject: reports:Fixed bug in br18-chart vms with known OS vs. unknown
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/24981/5/packaging/ovirt-reports/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data:

Line 219: -- Count by "Known" OS type and "Unknown" OS type.
Line 220: 
Line 221: SELECT DISTINCT
Line 222:     --If "Period" is "Daily" then
Line 223:     -- the "calendar_column" parameter is equal to "the_datetime" 
else "the_date" 
trailing whitespace..
Line 224:     $P!{calendar_column} AS the_date,
Line 225:     COALESCE (
Line 226:         os_type,
Line 227:         MAX ( os_type ) over ( partition by 1 ),


-- 
To view, visit http://gerrit.ovirt.org/24981
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdecb4e0bc4ac4ce5d6ab2000aa0812aa3ea5c2c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to