Eli Mesika has posted comments on this change. Change subject: webadmin: Fix Default OS selection for PPC ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24200/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1365: public void setSelectedItem(Integer value) { Line 1366: if (!AsyncDataProvider.osNameExists(value)) { Line 1367: DataCenterWithCluster dataCenterWithCluster = getDataCenterWithClustersList().getSelectedItem(); Line 1368: VDSGroup cluster = dataCenterWithCluster == null ? null : dataCenterWithCluster.getCluster(); Line 1369: if (cluster == null) { why not if (cluster != null) { super.setSelectedItem(AsyncDataProvider.getDefaultOs(cluster.getArchitecture())); } Line 1370: return; Line 1371: } Line 1372: super.setSelectedItem(AsyncDataProvider.getDefaultOs(cluster.getArchitecture())); Line 1373: } else { -- To view, visit http://gerrit.ovirt.org/24200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02843c1af1b3aecf2d3966bf836395550b0be554 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
