Maor Lipchuk has posted comments on this change. Change subject: core: Remove redundant validation ......................................................................
Patch Set 1: Not in all the cases, if the VM is previewed and don't contain one of the disks, it will not remove it from the images table. but this is a bug that occurs today, and actually, only when force is true, we validate it... I don't see any reason force should indicate this. Perhaps it is better to use this validation all the time then, without the force flag? -- To view, visit http://gerrit.ovirt.org/25176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c43440ef999bdbb573f6038a2f6b5d01411f2ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
