Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: libvirt and system PKI ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25142/4/src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py File src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py: Line 253: self.command.get('selinuxenabled'), Line 254: ), Line 255: raiseOnError=False, Line 256: ) Line 257: self._selinux_enabled = rc == 0 > it's not really needed but I think it would avoid confusion adding parenthe I agree. I copied this from engine/add_host.py ... Line 258: if not os.path.exists(ohostedcons.FileLocations.VDSMCERT): Line 259: self._generateVDSMcerts() Line 260: self._copy_vdsm_pki() Line 261: if not os.path.exists( -- To view, visit http://gerrit.ovirt.org/25142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74f44c46e6720ca8c62af1afa6df4a5d7c013b49 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tirabos...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
