Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing built-in extensions module ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25253/1/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/core/extensions/aaa/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/core/extensions/aaa/internal/InternalAuthenticator.java: Line 1: package org.ovirt.engine.core.extensions.aaa.internal; > .aaa.builtin.xxxx ? i was in a dilemma myself about this (if to include "builtin" ) maybe it's not that understandable that if you have "core" then it's a part of engine, hence built-in. Line 2: Line 3: import org.apache.commons.lang.ObjectUtils; Line 4: import org.ovirt.engine.core.aaa.AuthenticationResult; Line 5: import org.ovirt.engine.core.aaa.PasswordAuthenticator; -- To view, visit http://gerrit.ovirt.org/25253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7ea408b46548ffdad1bf56fb8ab54b68722a480 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
