Martin Peřina has posted comments on this change. Change subject: tools: Match transport names with EventNotificationMethod ......................................................................
Patch Set 2: (2 comments) EventNotificationMethod string value has to be the same as Transport.getName(). Since I cannot change transport name, I have to change string value. http://gerrit.ovirt.org/#/c/25204/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java: Line 1: package org.ovirt.engine.core.common; Line 2: Line 3: public enum EventNotificationMethod { Line 4: SMTP("smtp"), Line 5: SNMP("smnp"); > smnp -> snmp Done Line 6: Line 7: /** Line 8: * External string representation (database, text configuration) Line 9: */ http://gerrit.ovirt.org/#/c/25204/2/packaging/dbscripts/upgrade/03_05_0070_fix_event_notfication_method.sql File packaging/dbscripts/upgrade/03_05_0070_fix_event_notfication_method.sql: Line 1: ALTER TABLE event_subscriber RENAME COLUMN notification_method TO nmx; Line 2: ALTER TABLE event_subscriber ADD COLUMN notification_method CHARACTER VARYING(32); Line 3: Line 4: UPDATE event_subscriber SET notification_method = 'smtp' WHERE nmx = 'EMAIL'; Line 5: UPDATE event_subscriber SET notification_method = 'smnp' WHERE nmx = 'SNMP_TRAP'; > smnp -> snmp Done Line 6: Line 7: ALTER TABLE event_subscriber DROP COLUMN nmx; Line 8: Line 9: -- Name check constraint so it could be easily dropped in future if needed -- To view, visit http://gerrit.ovirt.org/25204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
