Yaniv Dary has posted comments on this change. Change subject: reports: br1 reports - added comments to queries ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24897/1/packaging/ovirt-reports/resources/Reports/Inventory/Hosts_Inventory_files/Hosts_Inventory_jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/Hosts_Inventory_files/Hosts_Inventory_jrxml.data: Line 75: CAST ( COALESCE ( memory_size_mb, 0.00 ) AS float ) Line 76: :: Line 77: numeric Line 78: / 1024, 1 Line 79: ) AS memory_size_mb not indented correctly. more than 4 spaces. Line 80: FROM v3_4_configuration_history_hosts Line 81: LEFT OUTER JOIN ( Line 82: SELECT Line 83: enum_translator_default.enum_type, Line 105: ON ( Line 106: v3_4_configuration_history_hosts.host_type = Line 107: host_type.enum_key Line 108: AND host_type.enum_type = 'HOST_TYPE' Line 109: ) This join in not indented correctly. it's confusing. Line 110: LEFT OUTER JOIN v3_4_configuration_history_clusters Line 111: ON ( Line 112: v3_4_configuration_history_hosts.cluster_id = Line 113: v3_4_configuration_history_clusters.cluster_id -- To view, visit http://gerrit.ovirt.org/24897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic842bb23ffe7f240ee20bfbe0144d30d7695e1a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
