Daniel Erez has uploaded a new change for review. Change subject: webadmin: DialogBoxWithKeyHandlers - remove ONKEYDOWN event ......................................................................
webadmin: DialogBoxWithKeyHandlers - remove ONKEYDOWN event DialogBoxWithKeyHandlers -> onPreviewNativeEvent: remove ONKEYDOWN event as onKeyPress might be called twice (due to ONKEYPRESS event). Which causes double execution of OK command when pressing enter key in Network dialog. Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Bug-Url: https://bugzilla.redhat.com/1058652 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/25236/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java index 81268a5..7f5fe12 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java @@ -15,8 +15,7 @@ protected void onPreviewNativeEvent(NativePreviewEvent event) { super.onPreviewNativeEvent(event); - if (keyPressHandler != null && - (event.getTypeInt() == Event.ONKEYPRESS || event.getTypeInt() == Event.ONKEYDOWN)) { + if (keyPressHandler != null && event.getTypeInt() == Event.ONKEYPRESS) { keyPressHandler.onKeyPress(event.getNativeEvent()); } } -- To view, visit http://gerrit.ovirt.org/25236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
