Vojtech Szocs has posted comments on this change. Change subject: webadmin: Host network interface subtab data ......................................................................
Patch Set 3: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/24852/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java: Line 204: } Line 205: Line 206: @Override Line 207: public void fireEvent(GwtEvent<?> event) { Line 208: eventBus.fireEventFromSource(event, modelProvider.getModel()); Nice catch with fireEventFromSource! Line 209: } http://gerrit.ovirt.org/#/c/24852/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java: Line 65: registerHandler(getEventBus().addHandler(ManualRefreshEvent.getType(), new ManualRefreshHandler() { Line 66: @Override Line 67: public void onManualRefresh(ManualRefreshEvent event) { Line 68: if (SubTabHostInterfacePresenter.this.isVisible() Line 69: && SubTabHostInterfacePresenter.this.getModelProvider().getModel().equals(event.getSource())) { Hm, we could use == as well for comparison, as we don't have custom equals() implementation for model classes. (IIRC, most of GWTP infra code working with models just compares references.) Current code change is OK too. Line 70: getView().removeContent(); Line 71: } Line 72: } Line 73: })); -- To view, visit http://gerrit.ovirt.org/24852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb539f95353992f589d251629be76f02a0196d18 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
