Vitor de Lima has posted comments on this change. Change subject: core, engine: Avoid migration in ppc64 ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/21522/13/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java: Line 357: if (StringUtils.isEmpty(group.getcpu_name())) { Line 358: doReturn(ArchitectureType.undefined).when(cmd).getArchitecture(); Line 359: } else { Line 360: doReturn(ArchitectureType.x86_64).when(cmd).getArchitecture(); Line 361: } > I prefer on one line blocks The "a ? b : c" operator is used to switch between return values of two expressions (b and c) according to a boolean (a). The code referenced here calls functions that do not return anything relevant, so I think this operator cannot be used. Line 362: Line 363: when(vdsGroupDAO.get(any(Guid.class))).thenReturn(createDefaultVdsGroup()); Line 364: when(vdsGroupDAO.getByName(anyString())).thenReturn(createDefaultVdsGroup()); Line 365: List<VDSGroup> vdsGroupList = new ArrayList<VDSGroup>(); -- To view, visit http://gerrit.ovirt.org/21522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4808f3e91ccf37462727a28d35f9f9faae1dfd6c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
