Alon Bar-Lev has posted comments on this change. Change subject: db: cleanup: trivial issues and bashism removal ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25126/1/packaging/dbscripts/refreshStoredProcedures.sh File packaging/dbscripts/refreshStoredProcedures.sh: Line 25: case $option in Line 26: s) SERVERNAME=$OPTARG;; Line 27: d) DATABASE=$OPTARG;; Line 28: u) USERNAME=$OPTARG;; Line 29: l) LOGFILE=$OPTARG;; > Aren't all those $OPTARG should be "$OPTARG" ? yes. Line 30: v) VERBOSE=true;; Line 31: h) usage; exit 0;; Line 32: \?) usage; exit 1;; Line 33: esac http://gerrit.ovirt.org/#/c/25126/1/packaging/dbscripts/unlock_entity.sh File packaging/dbscripts/unlock_entity.sh: Line 10: usage() { Line 11: cat << __EOF__ Line 12: Usage: $0 -t TYPE [-h] [-s SERVERNAME [-p PORT]] [-d DATABASE] [-u USERNAME] [-l LOGFILE] [-r] [-q] [-v] ENTITIES Line 13: Line 14: -t TYPE - The object type {vm | template | disk | snapshot} > TWS how could you see? Line 15: -s SERVERNAME - The database servername for the database (def. ${SERVERNAME}) Line 16: -p PORT - The database port for the database (def. ${PORT}) Line 17: -d DATABASE - The database name (def. ${DATABASE}) Line 18: -u USERNAME - The username for the database (def. engine) Line 20: -r - Recursive, unlocks all disks under the selected vm/template. Line 21: -q - Query db and display a list of the locked entites. Line 22: -v - Turn on verbosity (WARNING: lots of output) Line 23: -h - This help text. Line 24: ENTITIES - The list of object names in case of vm/template, UUIDs in case of a disk > TWS Done Line 25: Line 26: __EOF__ Line 27: } Line 28: -- To view, visit http://gerrit.ovirt.org/25126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
