Allon Mureinik has uploaded a new change for review.
Change subject: core: VdsDynamicDAO.testUpdateIfNeededPerformance
......................................................................
core: VdsDynamicDAO.testUpdateIfNeededPerformance
As this test is based on timing, it fails sporadically, thus generating
inappropriate noise during build time. Moreover, this is a performance
test, not a correctness test, and as such should not be part of the
regular test suite.
Change-Id: I4ce745eb4416ffac0ae7162f69e85b55bd003569
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java
1 file changed, 0 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/25117/1
diff --git
a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java
b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java
index 86dc6d9..0c4b7dd 100644
---
a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java
+++
b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java
@@ -4,7 +4,6 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
-import org.junit.Assert;
import org.junit.Test;
import org.ovirt.engine.core.common.businessentities.VDSStatus;
import org.ovirt.engine.core.common.businessentities.VdsDynamic;
@@ -87,28 +86,6 @@
assertNull(resultStatic);
VdsDynamic resultDynamic = dao.get(existingVds.getId());
assertNull(resultDynamic);
- }
-
- @Test
- public void testUpdateIfNeededPerformance() {
- VdsDynamic before = dao.get(existingVds.getId());
- long start;
- long diffNoChanges;
- long diffChanges;
-
- start = System.currentTimeMillis();
- for (int i = 0; i < 1000; ++i) {
- dao.update(before);
- }
- diffChanges = System.currentTimeMillis() - start;
-
- start = System.currentTimeMillis();
- for (int i = 0; i < 1000; ++i) {
- dao.updateIfNeeded(before);
- }
- diffNoChanges = System.currentTimeMillis() - start;
-
- Assert.assertTrue(diffChanges > diffNoChanges);
}
@Test
--
To view, visit http://gerrit.ovirt.org/25117
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ce745eb4416ffac0ae7162f69e85b55bd003569
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
