Eli Mesika has posted comments on this change. Change subject: userportal, webadmin: Prevent migration on the frontend ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/21523/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1385: getMigrateOnErrorOption_NO().setIsAvailable(true); Line 1386: getMigrateOnErrorOption_YES().setIsAvailable(true); Line 1387: getMigrateOnErrorOption_HA_ONLY().setIsAvailable(true); Line 1388: } else { Line 1389: getMigrateOnErrorOption_NO().setIsAvailable(true); This is the same in both blocks and can be put before the if Line 1390: getMigrateOnErrorOption_YES().setIsAvailable(false); Line 1391: getMigrateOnErrorOption_HA_ONLY().setIsAvailable(false); Line 1392: Line 1393: setMigrateOnErrorOption(MigrateOnErrorOptions.NO); http://gerrit.ovirt.org/#/c/21523/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1680: DataCenterWithCluster dataCenterWithCluster = Line 1681: (DataCenterWithCluster) getDataCenterWithClustersList().getSelectedItem(); Line 1682: if (dataCenterWithCluster == null) { Line 1683: return; Line 1684: } I think that it is more clean to wrap all the rest with if (dataCenterWithCluster != null) Line 1685: Line 1686: VDSGroup cluster = dataCenterWithCluster.getCluster(); Line 1687: Line 1688: Boolean isMigrationSupported = -- To view, visit http://gerrit.ovirt.org/21523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e6f82dd8906fe8aa3d6c9e28eaf0e155feef51c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
