Alon Bar-Lev has posted comments on this change. Change subject: packaging: pki: Use own openssl.conf ......................................................................
Patch Set 2: Code-Review-1 (1 comment) ok... patch is good, but I do not think we should merge this... so I vote -1. http://gerrit.ovirt.org/#/c/25055/2/packaging/bin/pki-common.sh.in File packaging/bin/pki-common.sh.in: Line 3: USRDIR="@ENGINE_USR@" Line 4: BINDIR="${USRDIR}/bin" Line 5: Line 6: OPENSSL_CONF="${PKIDIR}/openssl.conf" Line 7: export OPENSSL_CONF last time I checked, export XXX="AAA" is supported in POSIX. the one place I saw it unsupported is solaris 8 sh... :) Line 8: Line 9: die() { Line 10: local m="$1" Line 11: echo "$m" >&2 -- To view, visit http://gerrit.ovirt.org/25055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74f7000c590144ab821c797897d9036df956973e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
