Eli Mesika has posted comments on this change. Change subject: core: fixing restore.sh log file location ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25033/1/packaging/dbscripts/dbcustomfunctions.sh File packaging/dbscripts/dbcustomfunctions.sh: Line 17: LOGDIR="/var/log/ovirt-engine" Line 18: if [ -d ${LOGDIR} ]; then Line 19: LOGFILE="${LOGDIR}/$ME.log" Line 20: else Line 21: LOGFILE="$ME.log" > please be consistent with. Use $var or ${var} This was already merged , anyway this script is obsolete and all must use engine-backup from 3.3 Line 22: fi Line 23: DBOBJECT_OWNER="engine" Line 24: NOMD5="false" Line 25: MD5DIR="$(pwd)" -- To view, visit http://gerrit.ovirt.org/25033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd0742896e2fb5cfa79c75147ced47b94c37155 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
