Leonardo Bianconi has uploaded a new change for review.

Change subject: webadmin: [Fix] Template changes do not update OS
......................................................................

webadmin: [Fix] Template changes do not update OS

This change forces an OS list update in the "New Pool" and the
"Edit Pool" dialogs after the user selects a template. It was
introduced in order to avoid a class of bugs where the OS list
could show OSes for another architecture during the creation or
edition of VM Pools.

Change-Id: I959cdd6d133ead4f83cfb6cd68145519efb25489
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067735
Signed-off-by: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/25040/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
index 459d4d0..006c594 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
@@ -80,6 +80,7 @@
         }
 
         setupWindowModelFrom(template);
+        updateOSValues();
         updateHostPinning(template.getMigrationSupport());
         doChangeDefautlHost(template.getDedicatedVmForVds());
     }
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
index 561b7df..de64a78 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
@@ -127,6 +127,7 @@
                 getModel().getCdImage().setSelectedItem(vmBase.getIsoPath());
             }
 
+            updateOSValues();
             updateTimeZone(vmBase.getTimeZone());
             updateConsoleDevice(vmBase.getId());
             updateVirtioScsiEnabled(vmBase.getId(), vmBase.getOsId());


-- 
To view, visit http://gerrit.ovirt.org/25040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I959cdd6d133ead4f83cfb6cd68145519efb25489
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to