Liran Zelkha has uploaded a new change for review. Change subject: core: Remove error messages from log when adding host ......................................................................
core: Remove error messages from log when adding host When we add a host 3 errors on not finding vdsManager for the host appeared in the log. This patch fixes this issue. Change-Id: Ia17656dbfa0e16457565b04b849eb80ea74a8949 Bug-Url: https://bugzilla.redhat.com/1062438 Signed-off-by: lzel...@redhat.com <lzel...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/29/25029/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java index 2d16868..802f99a 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java @@ -218,7 +218,11 @@ } public void RemoveVds(Guid vdsId) { - VdsManager vdsManager = GetVdsManager(vdsId); + RemoveVds(vdsId, false); + } + + public void RemoveVds(Guid vdsId, boolean newHost) { + VdsManager vdsManager = GetVdsManager(vdsId, newHost); if (vdsManager != null) { vdsManager.dispose(); _vdsManagersDict.remove(vdsId); @@ -226,9 +230,15 @@ } public VdsManager GetVdsManager(Guid vdsId) { + return GetVdsManager(vdsId, false); + } + + public VdsManager GetVdsManager(Guid vdsId, boolean newHost) { VdsManager vdsManger = _vdsManagersDict.get(vdsId); if (vdsManger == null) { - log.errorFormat("Cannot get vdsManager for vdsid={0}", vdsId); + if (!newHost) { + log.errorFormat("Cannot get vdsManager for vdsid={0}", vdsId); + } } return vdsManger; } -- To view, visit http://gerrit.ovirt.org/25029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia17656dbfa0e16457565b04b849eb80ea74a8949 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
