Lior Vernia has uploaded a new change for review. Change subject: webadmin: Add room for long vNIC names ......................................................................
webadmin: Add room for long vNIC names Increased the width of the label field, and redesigned the widgets around it to conform to the new width. Change-Id: I6f7d73632440d88e76c544a1aee754f47bdf8f21 Bug-Url: https://bugzilla.redhat.com/1029973 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/25005/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java index b768397..77cd335 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java @@ -16,6 +16,7 @@ import com.google.gwt.event.logical.shared.ValueChangeEvent; import com.google.gwt.event.logical.shared.ValueChangeHandler; import com.google.gwt.event.shared.HandlerRegistration; +import com.google.gwt.resources.client.CssResource; import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiField; import com.google.gwt.user.client.ui.Widget; @@ -31,9 +32,17 @@ WidgetUiBinder uiBinder = GWT.create(WidgetUiBinder.class); } + interface Style extends CssResource { + String labelStyle(); + String contentStyle(); + } + @UiField @Path(value = "selectedItem") ProfileEditor profileEditor; + + @UiField + Style style; private String elementId; @@ -60,6 +69,8 @@ String vnicName = vnic.getName(); profileEditor.setLabel(vnicName); + profileEditor.addLabelStyleName(style.labelStyle()); + profileEditor.addContentWidgetStyleName(style.contentStyle()); profileEditor.setElementId(ElementIdUtils.createElementId(elementId, vnicName)); model.getSelectedItemChangedEvent().addListener(new IEventListener() { diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml index bb3f3b0..4673e01 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml @@ -5,6 +5,17 @@ xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor" xmlns:p="urn:import:org.ovirt.engine.ui.common.widget.profile"> + <ui:style type="org.ovirt.engine.ui.common.widget.profile.ProfileInstanceTypeEditor.Style"> + .labelStyle { + float: left; + width: 30px; + } + + .contentStyle { + float: left; + } + </ui:style> + <g:FlowPanel> <p:ProfileEditor ui:field="profileEditor" width="285px" /> </g:FlowPanel> -- To view, visit http://gerrit.ovirt.org/25005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6f7d73632440d88e76c544a1aee754f47bdf8f21 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
