Maor Lipchuk has posted comments on this change.
Change subject: core: Added disk alias to disk command events
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 28: @CustomLogFields({ @CustomLogField("DiskName") })
Why disk name and not disk alias?
Line 188: return getParameters().getDiskInfo().getDiskAlias();
I prefere that you use the the old disk alias name and not the one which we get
in the parameters.
If the operation will fail the user will get an audit log with the suggestion
alias name , and other users can not figure out which disk was tried to be
updated in the VM.
--
To view, visit http://gerrit.ovirt.org/4311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51539c31093c2aa7514e923a1e9c65c29aaff846
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
