Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing new Extension properties ......................................................................
Patch Set 3: (8 comments) http://gerrit.ovirt.org/#/c/24978/3//COMMIT_MSG Commit Message: Line 9: Introducing extension properties that are used to describe Line 10: the extension. Line 11: In addition, making use of them in the built-in extensions Line 12: Line 13: Topic: aaa AAA Line 14: Line 15: Change-Id: Ib3fa4c5ca319afee31930fd3a8a4e3009a80ea6d Line 10: the extension. Line 11: In addition, making use of them in the built-in extensions Line 12: Line 13: Topic: aaa Line 14: no space Line 15: Change-Id: Ib3fa4c5ca319afee31930fd3a8a4e3009a80ea6d http://gerrit.ovirt.org/#/c/24978/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalAuthenticator.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalAuthenticator.java: Line 27: } Line 28: Line 29: @Override Line 30: public void init() { Line 31: context.put(ExtensionProperties.AUTHOR, "oVirt"); The oVirt Project Line 32: context.put(ExtensionProperties.EXTENSION_NAME, "Internal Authentication"); Line 33: context.put(ExtensionProperties.LICENSE, "ASL 2.0"); Line 34: context.put(ExtensionProperties.HOME, "http://www.ovirt.org";); Line 35: context.put(ExtensionProperties.VERSION, "1.0"); Line 28: Line 29: @Override Line 30: public void init() { Line 31: context.put(ExtensionProperties.AUTHOR, "oVirt"); Line 32: context.put(ExtensionProperties.EXTENSION_NAME, "Internal Authentication"); please add (Built-in) Line 33: context.put(ExtensionProperties.LICENSE, "ASL 2.0"); Line 34: context.put(ExtensionProperties.HOME, "http://www.ovirt.org";); Line 35: context.put(ExtensionProperties.VERSION, "1.0"); Line 36: } Line 30: public void init() { Line 31: context.put(ExtensionProperties.AUTHOR, "oVirt"); Line 32: context.put(ExtensionProperties.EXTENSION_NAME, "Internal Authentication"); Line 33: context.put(ExtensionProperties.LICENSE, "ASL 2.0"); Line 34: context.put(ExtensionProperties.HOME, "http://www.ovirt.org";); I prefer http://ovirt.org... not important. Line 35: context.put(ExtensionProperties.VERSION, "1.0"); Line 36: } Line 31: context.put(ExtensionProperties.AUTHOR, "oVirt"); Line 32: context.put(ExtensionProperties.EXTENSION_NAME, "Internal Authentication"); Line 33: context.put(ExtensionProperties.LICENSE, "ASL 2.0"); Line 34: context.put(ExtensionProperties.HOME, "http://www.ovirt.org";); Line 35: context.put(ExtensionProperties.VERSION, "1.0"); 1.0 -> N/A as it is built in... Line 36: } http://gerrit.ovirt.org/#/c/24978/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java: Line 29: @Override Line 30: public void init() { Line 31: broker = LdapFactory.getInstance(getProfileName()); Line 32: context.put(ExtensionProperties.AUTHOR, "oVirt"); Line 33: context.put(ExtensionProperties.EXTENSION_NAME, "Provisional Authentication (LbapBroker code based)"); Internal Kerberos/LDAP Authentication Line 34: context.put(ExtensionProperties.LICENSE, "ASL 2.0"); Line 35: context.put(ExtensionProperties.HOME, "http://www.ovirt.org";); Line 36: context.put(ExtensionProperties.VERSION, "1.0"); Line 37: http://gerrit.ovirt.org/#/c/24978/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalDirectory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalDirectory.java: Line 47: @Override Line 48: public void init() { Line 49: broker = LdapFactory.getInstance(getProfileName()); Line 50: context.put(ExtensionProperties.AUTHOR, "oVirt"); Line 51: context.put(ExtensionProperties.EXTENSION_NAME, "Provisional Authorization (LbapBroker code based)"); Internal Kerberos/LDAP Authorization Line 52: context.put(ExtensionProperties.LICENSE, "ASL 2.0"); Line 53: context.put(ExtensionProperties.HOME, "http://www.ovirt.org";); Line 54: context.put(ExtensionProperties.VERSION, "1.0"); Line 55: } -- To view, visit http://gerrit.ovirt.org/24978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3fa4c5ca319afee31930fd3a8a4e3009a80ea6d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
