Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding the ability to enabled/disable an extension via engine configration file ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/24977/2/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 206: for (ExtensionEntry entry : loadedEntries.values()) { Line 207: //Engine local config might override the enabled property of the configuration Line 208: //if a proper ENGINE_EXTENSION_ENABLE_<NAME> entry exists at the engine config. Line 209: entry.enabled = Line 210: EngineLocalConfig.getInstance().getBoolean( please do not add new line after = operator... should be: entry.enabled = EngineLocalConfig. no need for getInstance() in a loop... please store a reference. Line 211: "ENGINE_EXTENSION_ENABLE_" + entry.getName(), Line 212: entry.enabled Line 213: ); Line 214: if (entry.enabled) { Line 207: //Engine local config might override the enabled property of the configuration Line 208: //if a proper ENGINE_EXTENSION_ENABLE_<NAME> entry exists at the engine config. Line 209: entry.enabled = Line 210: EngineLocalConfig.getInstance().getBoolean( Line 211: "ENGINE_EXTENSION_ENABLE_" + entry.getName(), why don't you have a constant for one time used string :))) don't get me wrong... I think this is good, but then you should remove the other constants as well. I suggest ENABLED to be synced with ovirt.engine.extension.enabled Line 212: entry.enabled Line 213: ); Line 214: if (entry.enabled) { Line 215: try { -- To view, visit http://gerrit.ovirt.org/24977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I817d58f16fa32d37379a9f98d697538df75c28a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
