Eli Mesika has uploaded a new change for review. Change subject: core:NPE when attempting to delete Everyone... ......................................................................
core:NPE when attempting to delete Everyone... NPE when attempting to delete Everyone group from API This patch addresses an NPE thrown when trying to delete the Everyone group from the API. This exceptions cause the detail field to be skipped in the respond. Change-Id: Ic1faf6f97713f6adfce701126617b0463c118ce4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060528 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/24952/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java index 5f0f45c..da1ce34 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java @@ -45,7 +45,9 @@ if (mGroup == null && !getGroupId().equals(Guid.Empty)) { DbGroup dbGroup = DbFacade.getInstance().getDbGroupDao().get(getGroupId()); Directory directory = DirectoryManager.getInstance().getDirectory(dbGroup.getDomain()); - mGroup = directory.findGroup(dbGroup.getExternalId()); + if (directory != null) { + mGroup = directory.findGroup(dbGroup.getExternalId()); + } } return mGroup; } -- To view, visit http://gerrit.ovirt.org/24952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic1faf6f97713f6adfce701126617b0463c118ce4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
