Liron Ar has posted comments on this change. Change subject: engine: Warn user when a boot disk is configured as read-only ......................................................................
Patch Set 1: (2 comments) please see inline comments. should be also added to AttachDiskToVmCommand http://gerrit.ovirt.org/#/c/24883/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java: Line 344: Line 345: @Override Line 346: protected void executeVmCommand() { Line 347: if (getParameters().getDiskInfo().isBoot() && getParameters().getDiskInfo().getReadOnly()) { Line 348: AuditLogDirector.log(this, AuditLogType.BOOT_DISK_IS_READ_ONLY); there's an issue here, we might fail to create this disk while still have that audit log. For image disks this message should be logged currently on the endSuccesfully method, for luns after line 357. Line 349: } Line 350: Line 351: getParameters().getDiskInfo().setId(Guid.newGuid()); Line 352: getParameters().setEntityInfo(new EntityInfo(VdcObjectType.Disk, getParameters().getDiskInfo().getId())); http://gerrit.ovirt.org/#/c/24883/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 112: @Override Line 113: protected void executeVmCommand() { Line 114: ImagesHandler.setDiskAlias(getParameters().getDiskInfo(), getVm()); Line 115: Line 116: if (getNewDisk().isBoot() && getNewDisk().getReadOnly()) { this will appear now on every update to the disk, even if we only changed it's alias/extended it which is wrong. Line 117: AuditLogDirector.log(this, AuditLogType.BOOT_DISK_IS_READ_ONLY); Line 118: } Line 119: Line 120: if (shouldResizeDiskImage()) { -- To view, visit http://gerrit.ovirt.org/24883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89dfc4492352b650eeafd89723e3d50de19bd5eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: A Burden <abur...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
