Nir Soffer has uploaded a new change for review.

Change subject: oschedproxyd: Prevent XMLRPC threads from delaying shutdown
......................................................................

oschedproxyd: Prevent XMLRPC threads from delaying shutdown

The threads created by the XMLRPC server are not daemon threads, so they
may delay vdsm shutdown if a long request happen to run during shutdown.
This patch configure XMLRPC server to use daemon threads.

Change-Id: Ide0f8b6b55c548f28e8a5ef599c84c71fb4cdd01
Signed-off-by: Nir Soffer <nsof...@redhat.com>
---
M src/ovirtscheduler/oschedproxyd.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-scheduler-proxy 
refs/changes/11/24911/1

diff --git a/src/ovirtscheduler/oschedproxyd.py 
b/src/ovirtscheduler/oschedproxyd.py
index 2517c15..de42ed6 100644
--- a/src/ovirtscheduler/oschedproxyd.py
+++ b/src/ovirtscheduler/oschedproxyd.py
@@ -26,7 +26,9 @@
 
 class SimpleThreadedXMLRPCServer(SocketServer.ThreadingMixIn,
                                  SimpleXMLRPCServer.SimpleXMLRPCServer):
-    pass
+
+    # Create daemon threads so shutdown is not delayed by request thread.
+    daemon_threads = True
 
 
 def setup_logging(path):


-- 
To view, visit http://gerrit.ovirt.org/24911
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide0f8b6b55c548f28e8a5ef599c84c71fb4cdd01
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to