Liron Ar has posted comments on this change. Change subject: core: allow to detach domain with ovf store ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/24180/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java: Line 104: @Override Line 105: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 106: return Collections.singletonMap(getParameters().getStorageDomainId().toString(), Line 107: LockMessagesMatchUtil.makeLockingPair(LockingGroup.STORAGE, Line 108: VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED)); > Why is this relevant to the patch? beacause if we allow to detach a domain with ovf store, we need to sync that with the ovf update and that's the way to do that. anyway, i separated it to another change if that's the way you prefer it. Line 109: } -- To view, visit http://gerrit.ovirt.org/24180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icde56b54bd11c617056c819fcdbacac71753e264 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
