Itamar Heim has posted comments on this change. Change subject: core: WIP: is_inheritable property to MLA entities ......................................................................
Patch Set 5: (5 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java Line 11: CREATE_VM(1, RoleType.USER, VdcObjectType.VM, false), will an admin creating a VM also get a VmOwner (etc.) permission on created objects (or is inheritance assumed for admin permissions today)? Line 37: CREATE_HOST(100, RoleType.ADMIN, VdcObjectType.VDS, false), how will this work exactly for admins? we don't have HostOwner role afair? isn't this mostly relevant for user roles? Line 49: CREATE_VM_POOL(300, RoleType.USER, VdcObjectType.VmPool, true), 1. not sure why this is a user permissions - don't remember this in user portal. 2. why isn't this 'false' on inheritance (not saying it's wrong, just worth a comment on logic compared to other create permission) Line 77: CONFIGURE_QUOTA(900, RoleType.ADMIN, VdcObjectType.Quota, true), so where is create_quota? Line 81: CREATE_GLUSTER_VOLUME(1000, RoleType.ADMIN, VdcObjectType.GlusterVolume, true), how is this different from other create handled above? -- To view, visit http://gerrit.ovirt.org/4484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8732306c515bade05db5cb95b9d571003fdec177 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
