Alon Bar-Lev has posted comments on this change. Change subject: 7. [WIP] core: introducing profile name ot authenticator classes. ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/24607/5//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-02-18 05:49:45 +0200 Line 4: Commit: Yair Zaslavsky <yzasl...@redhat.com> Line 5: CommitDate: 2014-02-22 14:59:53 +0200 Line 6: Line 7: 7. [WIP] core: introducing profile name ot authenticator classes. please remove prefix Line 8: Line 9: An authenticator should be aware to the name of the profile it is Line 10: associated with Line 11: Line 7: 7. [WIP] core: introducing profile name ot authenticator classes. Line 8: Line 9: An authenticator should be aware to the name of the profile it is Line 10: associated with Line 11: please add: Topic: AAA Line 12: Change-Id: I0d24575f4f07d0a7ab0c4fe1aa4825fdc04a3b18 http://gerrit.ovirt.org/#/c/24607/5/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorFactory.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorFactory.java: Line 12: Line 13: private static final String PROFILE_NAME_KEY = "ovirt.engine.aaa.authn.profile.name"; Line 14: Line 15: public Authenticator create(Configuration config) throws ConfigurationException { Line 16: String profileName = config.getString(PROFILE_NAME_KEY); why do you need profileName temp variable? Line 17: Authenticator authenticator = createImpl(profileName, config); Line 18: return authenticator; Line 19: } Line 20: Line 13: private static final String PROFILE_NAME_KEY = "ovirt.engine.aaa.authn.profile.name"; Line 14: Line 15: public Authenticator create(Configuration config) throws ConfigurationException { Line 16: String profileName = config.getString(PROFILE_NAME_KEY); Line 17: Authenticator authenticator = createImpl(profileName, config); why do you need authenticator temp variable? Line 18: return authenticator; Line 19: } Line 20: Line 21: protected abstract Authenticator createImpl(String profileName, Configuration config) throws ConfigurationException; -- To view, visit http://gerrit.ovirt.org/24607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d24575f4f07d0a7ab0c4fe1aa4825fdc04a3b18 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
