Frank Kobzik has posted comments on this change. Change subject: backend: Control virtio rng device ......................................................................
Patch Set 6: (4 comments) Don't review the change for now - I need to think about addressing Omer's comment in VmRngDevice. http://gerrit.ovirt.org/#/c/18176/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java: Line 7: Line 8: /** Line 9: * This class represents paravirtualized rng device. Line 10: */ Line 11: public class VmRngDevice extends IVdcQueryable implements Serializable { > would it make sense to extend vmDevice? this actually sounds pretty good since it would eliminate converting VmDevice instances to VmRngDevice instances and vice versa. I try to refactor it in next patchset. Line 12: Line 13: private Guid vmId; Line 14: private Guid id; Line 15: http://gerrit.ovirt.org/#/c/18176/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1519: @DefaultValueAttribute("1") Line 1520: AutoStartVmsRunnerIntervalInSeconds, Line 1521: Line 1522: @TypeConverterAttribute(Boolean.class) Line 1523: @DefaultValueAttribute("false") > its better to put the newer value (true) Done Line 1524: VirtIoRngDeviceSupported, Line 1525: Line 1526: @TypeConverterAttribute(Boolean.class) Line 1527: @DefaultValueAttribute("true") http://gerrit.ovirt.org/#/c/18176/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 837: WATCHDOG_MODEL_REQUIRED(ErrorType.BAD_PARAMETERS), Line 838: Line 839: //rng device Line 840: RNG_NOT_FOUND(ErrorType.CONFLICT), Line 841: RNG_ALREADY_EXISTS(ErrorType.CONFLICT), > please allign to name convention (ACTION_TYPE_FAILED_RNG_NOT_FOUND..) Done Line 842: Line 843: // network QoS Line 844: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES(ErrorType.BAD_PARAMETERS), Line 845: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES(ErrorType.BAD_PARAMETERS), http://gerrit.ovirt.org/#/c/18176/6/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 131: select fn_db_add_config_value('FindFenceProxyRetries','3','general'); Line 132: select fn_db_add_config_value('FreeSpaceCriticalLowInGB','5','general'); Line 133: select fn_db_add_config_value('FreeSpaceLow','10','general'); Line 134: Line 135: -- VirtIO Random Number Generator device enabled > remove whitespace Done Line 136: select fn_db_add_config_value('VirtIoRngDeviceSupported','false','3.0'); Line 137: select fn_db_add_config_value('VirtIoRngDeviceSupported','false','3.1'); Line 138: select fn_db_add_config_value('VirtIoRngDeviceSupported','false','3.2'); Line 139: select fn_db_add_config_value('VirtIoRngDeviceSupported','false','3.3'); -- To view, visit http://gerrit.ovirt.org/18176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc26a484c84244074426f4b0c790e2cc4ebb8da6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
