Liron Ar has posted comments on this change. Change subject: engine: Block setting a plugged disk as read only when the vm is running ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24797/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 257: return true; Line 258: } Line 259: Line 260: private boolean validateCanUpdateReadOnly() { Line 261: if (shouldUpdateReadOnly() && getVm().getStatus() != VMStatus.Down && vmDeviceForVm.getIsPlugged()) { > please also block this in the UI (if it's not blocked) just noticed that we do block other properties update on line 138, so diesregard the first comment. please also block on the UI level when the disk is plugged. other than that +2. Line 262: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN); Line 263: } Line 264: return true; Line 265: } -- To view, visit http://gerrit.ovirt.org/24797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd16d91e02f26f2d6697b31233669a80a98534c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
