Omer Frenkel has posted comments on this change.
Change subject: core:Support remove of shared disk.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 178: validDisktoDelete = validDisktoDelete && validate(new
SnapshotsValidator().vmNotDuringSnapshot(vm.getId()))
no need for validDisktoDelete = validDisktoDelete &&
Line 277: for (VM vm : listVms) {
please check why vm need to be down,
i think we should call update vm in spm regardless to the vm status (maybe
except image locked)
--
To view, visit http://gerrit.ovirt.org/4494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cfcee158d7138d2970b9df12ff5c6da237ed164
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
