Alexander Wels has posted comments on this change. Change subject: webadmin: fix events not updating ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/24409/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java: Line 83: } Line 84: }); Line 85: Line 86: updateController(); Line 87: getModelTimer().setRefreshRate(readRefreshRate()); > Small thing: Done Line 88: Line 89: // Add handler to be notified when the application window gains or looses its focus Line 90: eventBus.addHandler(ApplicationFocusChangeEvent.getType(), new ApplicationFocusChangeHandler() { Line 91: @Override http://gerrit.ovirt.org/#/c/24409/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java: Line 191: public final void setEventBus(EventBus eventBus) { Line 192: if (eventBus == null) { Line 193: unregisterHandlers(); Line 194: this.eventBus = null; Line 195: } else if (this.eventBus == null || this.eventBus != eventBus){ > IIUC, this is to guard against multiple potential setEventBus calls with sa You missed the following possibility: * this.eventBus is not null (aka it has been set). * And we are assigning a new eventbus for whatever reason, thus this.eventBus != eventBus. In that case we do want to register the handlers to the NEW event bus. Line 196: this.eventBus = eventBus; Line 197: registerHandlers(); Line 198: } Line 199: } -- To view, visit http://gerrit.ovirt.org/24409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I484dff03a5f90679ccaa6ca0b58a50a2b3083df9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
