Omer Frenkel has posted comments on this change.
Change subject: engine: Start Rebalance Gluster Volume command
......................................................................
Patch Set 11: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
Line 62: //addToTaskListInDb(getVdsGroupId(),
getGlusterVolumeName(), getParameters().isForceAction());
i think it is better not to add commented code, as it tend to become garbage in
the code, i think it can be added once its relevant.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 722: ACTION_TYPE_FAILED_GLUSTER_VOLUME_IS_NOT_DISTRIBUTED=Cannot ${action}
${type}. Gluster Volume is not distributed.
VdcBllMessages.java was added with 2 more values, so the need translation as
well
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1865: String ACTION_TYPE_FAILED_GLUSTER_VOLUME_IS_NOT_DISTRIBUTED();
same here
--
To view, visit http://gerrit.ovirt.org/4388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7120a102df7dd37eaff83b07d876531058a415
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
