Allon Mureinik has posted comments on this change. Change subject: core: allow to remove storage pool when the only disks are ovf stores ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/24644/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java: Line 326: return failCanDoAction(VdcBllMessages.ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS); Line 327: } Line 328: for (StorageDomain domain : poolDomains) { Line 329: // check that there are no images on data domains Line 330: if ((domain.getStorageDomainType() == StorageDomainType.Data || domain.getStorageDomainType() == StorageDomainType.Master)) { some time in the foreseeable future, this should be changed to domain.getStorageDomainType().isData() - probably not in this patch. Line 331: StorageDomainValidator storageDomainValidator = new StorageDomainValidator(domain); Line 332: if (!validate(storageDomainValidator.isDomainHasNoImages(VdcBllMessages.ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_IMAGES, true))) { Line 333: return false; Line 334: } http://gerrit.ovirt.org/#/c/24644/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java: Line 90: } Line 91: Line 92: private DbFacade getDbFacade() { Line 93: return DbFacade.getInstance(); Line 94: } This code should be reused in the detach flow too. Line 95: Line 96: private static Integer getLowDiskSpaceThreshold() { Line 97: return Config.<Integer> getValue(ConfigValues.FreeSpaceCriticalLowInGB); Line 98: } -- To view, visit http://gerrit.ovirt.org/24644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifca867af242984aa9292938b88f568f51a4a147c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
