Gilad Chaplik has posted comments on this change. Change subject: core: minor cleanups ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/24160/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 37: @LockIdNameAttribute(isReleaseAtEndOfExecute = false) Line 38: public class MigrateVmCommand<T extends MigrateVmParameters> extends RunVmCommandBase<T> { Line 39: Line 40: private Guid destinationVdsId; Line 41: private VDS cachedDestinationVds; a comment here will be more than welcomed, I've already forgotten what it means :) + sorry to be a nag, this addition is pure logic, either change the commit msg (not clean up) or separate to another patch (prefer the second). Line 42: private boolean forcedMigrationForNonMigratableVm; Line 43: Line 44: /** Used to log the migration error. */ Line 45: private VdcBllErrors migrationErrorCode; -- To view, visit http://gerrit.ovirt.org/24160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa22569d9195f69cec7fa9c0a4931b2975e41ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
