Liron Ar has submitted this change and it was merged. Change subject: core: AddDiskCommand - added disk can never be a disk snapshot ......................................................................
core: AddDiskCommand - added disk can never be a disk snapshot When adding a disk the added disk can never be a disk snapshot, Currently when adding DiskImages the disk's Image object is "active" member has a default value of false, which leads to wrongly treat that disk as a disk snapshot through validations rather than a regular added disk. Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Signed-off-by: Liron Aravot <lara...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
