Roy Golan has posted comments on this change. Change subject: core: change asyncRunningVms to be Set ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/24552/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 53: newSetFromMap the javadoc of this methods states that this is redundant doning that for HashMap implementations that already has corresponding Set implementation your view of viewing it as a set is good. and in order to view the Map as a set we just need to Set<Guid> asyncVms = new ConcurrentHashMap<Guid, Boolean>().keySet() -- To view, visit http://gerrit.ovirt.org/24552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I807936d76ee7298a126e7dd61d75cbb345e06829 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
