Roy Golan has posted comments on this change. Change subject: core: remove redundant transaction on run vm ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24551/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java: Line 43: setInitialized > I don't mind to do it if that bothers you, but can you please explain why? its noise and not related. when I'll come back in git history I'll ask myself why did you change it? it can create bugs so you should be botherred by that as well -- To view, visit http://gerrit.ovirt.org/24551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9819a9defe421deab3badf1e4e1e62e7e3e3e92f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
