Allon Mureinik has submitted this change and it was merged. Change subject: core: Enable AuditLogDAOTest.testLongMessageSave() ......................................................................
core: Enable AuditLogDAOTest.testLongMessageSave() AuditLogDAO.testLongMessageSave() has been @Ignored since it consistently fails. This patch modifies it to stop relying on the new record's generated ID, so it can conceivably pass, in a similar fashion to testSave(). Additionally, the newly inserted AuditLog was made external (since internal messages do not get truncated) and the MaxAuditLogMessageLength config value was introduced to the fixtures database since the underlying InsertExternalAuditLog stored procedure relies on it, and VdcOptionDAOTest was amended accordingly. Change-Id: I30189046c8ad97256717e3c804996a22bf1b5d9b Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 21 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30189046c8ad97256717e3c804996a22bf1b5d9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
