Martin Sivák has posted comments on this change. Change subject: webadmin, backend: control of hosted engine maintenance mode ......................................................................
Patch Set 2: Code-Review+1 (2 comments) I think this is OK and I only have two questions. Someone who knows GWT better has to take a look though. http://gerrit.ovirt.org/#/c/24605/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java: Line 204: List<String> nonMigratableVmDescriptionsToFrontEnd = new ArrayList<String>(); Line 205: for (VM vm : vms) { Line 206: if (vm.isHostedEngine()) { Line 207: // The Hosted Engine vm is migrated by the HA agent Line 208: continue; What does this accomplish in this loop? Is it supposed to skip the getMigrationSupport check only? Why not merge the ifs then? Or xplain the logic here a bit better please. Line 209: } Line 210: if (vm.getMigrationSupport() != MigrationSupport.MIGRATABLE) { Line 211: nonMigratableVmDescriptionsToFrontEnd.add(vm.getName()); Line 212: } http://gerrit.ovirt.org/#/c/24605/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 940: ISCSI_BOND_REMOVE_SUCCESS(10404), Line 941: ISCSI_BOND_REMOVE_FAILED(10405, AuditLogSeverity.ERROR), Line 942: Line 943: // Hosted Engine Line 944: USER_SET_HOSTED_ENGINE_MAINTENANCE(10450), when hosted engine maintenance fails, shouldn't we signalize an error instead of just warning? Line 945: USER_FAILED_TO_SET_HOSTED_ENGINE_MAINTENANCE(10451, AuditLogSeverity.WARNING); Line 946: Line 947: private int intValue; Line 948: // indicates time interval in seconds on which identical events from same instance are suppressed. -- To view, visit http://gerrit.ovirt.org/24605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
