Tomas Jelinek has posted comments on this change. Change subject: Engine: RFE: add hostname attribute for windows sysprep ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/24578/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java: Line 431: return item.getValue().startsWith("(GMT) Greenwich"); //$NON-NLS-1$ Line 432: } Line 433: })); Line 434: Line 435: // if not proven to be hidden, show it this comment is not needed anymore (see comment under) Line 436: isWindowsOS = vm != null ? AsyncDataProvider.isWindowsOsType(vm.getOsId()) : true; Line 437: getDomain().setIsAvailable(isWindowsOS); Line 438: Line 439: VmInit vmInit = (vm != null) ? vm.getVmInit() : null; Line 433: })); Line 434: Line 435: // if not proven to be hidden, show it Line 436: isWindowsOS = vm != null ? AsyncDataProvider.isWindowsOsType(vm.getOsId()) : true; Line 437: getDomain().setIsAvailable(isWindowsOS); The "getDomain().setIsAvailable(isWindowsOS);" is not needed anymore since there are two different domains in two different panels (cloudInitOptionsContent and syspreptOptionsContent) and they are hidden/shown according to the OS type (and together with them also the domains). Line 438: Line 439: VmInit vmInit = (vm != null) ? vm.getVmInit() : null; Line 440: if (vmInit != null) { Line 441: if (!StringHelper.isNullOrEmpty(vmInit.getHostname())) { Line 535: })); Line 536: } Line 537: Line 538: public boolean validate() { Line 539: getHostname().setIsValid(true); missing getWindowsHostname().setIsValid(true); Line 540: if (getHostnameEnabled()) { Line 541: if (this.isWindowsOS) { Line 542: getWindowsHostname().validateEntity(new IValidation[] { new HostnameValidation() }); Line 543: } else { Line 623: } Line 624: } Line 625: } Line 626: } Line 627: missing "&& getWindowsHostname().getIsValid()" Line 628: return getHostname().getIsValid() Line 629: && getDomain().getIsValid() Line 630: && getAuthorizedKeys().getIsValid() Line 631: && getTimeZoneList().getIsValid() -- To view, visit http://gerrit.ovirt.org/24578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a787c7436f53a521835ff3a86abc9ef60251003 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
