Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: CustomPropertyValidation blank string ......................................................................
webadmin: CustomPropertyValidation blank string Fixed up the way a blank string is tested. Before this patch, it's trim()ed and compared to "" using StringHelper.stringEquals. Since trim() is called on this string, we can assume it's not null, so StringHelper.stringEquals is redundant. Since we know we have a non-null instance, we can simply used the optimized isEmpty(). An additional advantage is removing another call to StringHelper.stringsEqual, moving one step closer to eliminating this method. Change-Id: I3592a500d5af41593a3f8f9eb1e888d6ac22cf04 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3592a500d5af41593a3f8f9eb1e888d6ac22cf04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
