Eli Mesika has posted comments on this change. Change subject: tools: notifier: Refactor model and DB mapping of eventNotificationMethods. ......................................................................
Patch Set 33: Code-Review+1 (1 comment) OK from my side , Yair will approve finally Please rename the upgrade script since we have already 0010 for 3.5 http://gerrit.ovirt.org/#/c/22135/33/packaging/dbscripts/upgrade/03_05_0010_event_notification_methods.sql File packaging/dbscripts/upgrade/03_05_0010_event_notification_methods.sql: Line 1: -- DROP event_notification_methods - redundant table Please rename the upgrade script Line 2: ALTER TABLE event_subscriber DROP CONSTRAINT fk_event_subscriber_event_notification_methods; Line 3: DROP TABLE event_notification_methods ; Line 4: Line 5: -- save EventNotificationMethod as string with constraint. -- To view, visit http://gerrit.ovirt.org/22135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b71c4e78bbdca3d02d2ac4ef419b9d3d7d58761 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
