mooli tayer has posted comments on this change. Change subject: tools: notifier: implement and use transport.idle(). ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/24472/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 132: for (AuditLogEvent event : eventsManager.getAuditLogEvents()) { Line 133: firstMatchSimpleFilter.processEvent(event); Line 134: eventsManager.updateAuditLogEventProcessed(event.getId()); Line 135: } Line 136: deleteObsoleteHistoryData(); > if we do we need to add configuration variable to specify how many idle int We already have DAYS_TO_KEEP_HISTORY which we need to maintain so doing it every idle makes sense? (I would not like to see two config values dealing with this marginal issue) Anyway because there is no more time I would prefer to do this after we merge. Line 137: log.debug("Finished event notification service iteration"); Line 138: } catch (SQLException se) { Line 139: distributeDbDownEvent(); Line 140: throw se; -- To view, visit http://gerrit.ovirt.org/24472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
